Hi @dharrigan,

can you do me three favours on this one?

• Looks like your editor does lots of formatting corrections. While this is appreciated, it makes it very hard to see what actually has changed. Can you just include the changes in this commit and if you want a second PR with the formatting changes that do not fix behaviour?
• Can you change the commit MSG to have the title in like "DATACOUCH-23 - ...MY HEADLINE..." and then the rest afterwards. Github and git mostly show only the first line without a click more and then we have it consinstently.
• And while you're at it, can you rebase it against master?

Thanks much, looking forward to it :)

Hi,

Sure. I'll get on it shortly. Glad to help!

Would you happen to have your settings for style on this (I use IntelliJ
too) so that I can ensure styling is the same (tbh, I did these changes in
VIM :-))

-=david=-

On 1 October 2013 08:51, Michael Nitschinger notifications@github.comwrote:

Hi @dharrigan https://github.com/dharrigan,

can you do me three favours on this one?

• Looks like your editor does lots of formatting corrections. While
  this is appreciated, it makes it very hard to see what actually has
  changed. Can you just include the changes in this commit and if you want a
  second PR with the formatting changes that do not fix behaviour?
• Can you change the commit MSG to have the title in like
  "DATACOUCH-23 - ...MY HEADLINE..." and then the rest afterwards. Github and
  git mostly show only the first line without a click more and then we have
  it consinstently.
• And while you're at it, can you rebase it against master?

Thanks much, looking forward to it :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-25431223
.

I prefer encrypted and signed messages. KeyID: B20A22F9
Fingerprint: 110A F423 3647 54E2 880F ADAD 1C52 85BF B20A 22F9

"It is not usually until you've built and used a version of the program
that you understand the issues well enough to get the design right." - Rob
Pike, Brian Kernighan.

No trees were harmed in the sending of this message, however, a number of
electrons were inconvenienced.

I haven't developed a style for this yet, just use the settings you see there (don't override all the formatting) and it should be good. Once the codebase grows and we get to a 1.0 final release, I'll revisit the markup and get it into shape.